Skip to content

Commit

Permalink
remove wait-only flag because it is no longer used
Browse files Browse the repository at this point in the history
  • Loading branch information
darinyu committed Feb 29, 2024
1 parent 3589a1d commit 16baeb1
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
9 changes: 0 additions & 9 deletions metaflow/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,13 +473,6 @@ def echo_unicode(line, **kwargs):
help="Pathspec of the origin task for this task to clone. Do "
"not execute anything.",
)
@click.option(
"--clone-wait-only/--no-clone-wait-only",
default=False,
show_default=True,
help="If specified, waits for an external process to clone the task",
hidden=True,
)
@click.option(
"--clone-run-id",
default=None,
Expand Down Expand Up @@ -519,7 +512,6 @@ def step(
retry_count=None,
max_user_code_retries=None,
clone_only=None,
clone_wait_only=False,
clone_run_id=None,
decospecs=None,
ubf_context="none",
Expand Down Expand Up @@ -575,7 +567,6 @@ def step(
task_id,
clone_only,
retry_count,
wait_only=clone_wait_only,
)
else:
task.run_step(
Expand Down
2 changes: 0 additions & 2 deletions metaflow/runtime.py
Original file line number Diff line number Diff line change
Expand Up @@ -1396,8 +1396,6 @@ def _launch(self):
# disabling sidecars for cloned tasks due to perf reasons
args.top_level_options["event-logger"] = "nullSidecarLogger"
args.top_level_options["monitor"] = "nullSidecarMonitor"
if self.task.should_skip_cloning:
args.command_options["clone-wait-only"] = True
else:
# decorators may modify the CLIArgs object in-place
for deco in self.task.decos:
Expand Down
4 changes: 0 additions & 4 deletions metaflow/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,15 +285,11 @@ def clone_only(
task_id,
clone_origin_task,
retry_count,
wait_only=False,
):
if not clone_origin_task:
raise MetaflowInternalError(
"task.clone_only needs a valid clone_origin_task value."
)
if wait_only:
print("Not cloning anything in wait_only mode.")
return
origin_run_id, _, _ = clone_origin_task.split("/")

# If we actually have to do the clone ourselves, proceed...
Expand Down

0 comments on commit 16baeb1

Please sign in to comment.