Removed multiple unused modules and non-accessed assignments (#865)

* Respect alphabetical order when importing modules

* import sys

* Remove unused module

* Elegantly check the Python version before importing the modules and converting to local time.

* Remove unused module

* Decouple LBYL  from  PR

* ./metaflow/cli.py:18:1 '.util.to_unicode' imported but unused

* ./metaflow/debug.py:3:1 'os' imported but unused

* multiple unused imports

* unused variable

* unused import

* useless varaible assign

* unused imports

* removed junk testing file

Co-authored-by: Savin <savingoyal@gmail.com>
Co-authored-by: Romain <romain-intel@users.noreply.github.com>

metaflow/cli.py

@@ -20,7 +20,6 @@
     decompress_list,
     write_latest_run_id,
     get_latest_run_id,
-    to_unicode,
 )
 from .task import MetaflowTask
 from .exception import CommandException, MetaflowException

metaflow/debug.py

@@ -1,6 +1,5 @@
 from __future__ import print_function
 import sys
-import os
 
 from functools import partial
 

metaflow/decorators.py

@@ -1,4 +1,3 @@
-import traceback
 from functools import partial
 import re
 import os

metaflow/flowspec.py

@@ -1,6 +1,5 @@
 from itertools import islice
 import os
-import sys
 import inspect
 import traceback
 from types import FunctionType, MethodType
@@ -9,7 +8,6 @@
 from .parameters import Parameter
 from .exception import (
     MetaflowException,
-    MetaflowInternalError,
     MissingInMergeArtifactsException,
     UnhandledInMergeArtifactsException,
 )

metaflow/includefile.py

@@ -3,11 +3,8 @@
 import io
 import json
 import os
-import pickle
-import tempfile
 
 from hashlib import sha1
-from shutil import move
 
 import click
 

metaflow/metaflow_environment.py

@@ -2,10 +2,10 @@
 import platform
 import sys
 
-from .util import get_username, to_unicode
+from .util import get_username
 from . import metaflow_version
 from metaflow.exception import MetaflowException
-from metaflow.mflog import BASH_MFLOG, BASH_SAVE_LOGS
+from metaflow.mflog import BASH_MFLOG
 from . import R
 
 version_cache = None

metaflow/multicore_utils.py

@@ -63,7 +63,6 @@ def parallel_imap_unordered(func, iterable, max_parallel=None, dir=None):
     if max_parallel is None:
         max_parallel = cpu_count()
 
-    ret = []
     args_iter = iter(iterable)
     pids = [_spawn(func, arg, dir) for arg in islice(args_iter, max_parallel)]
 

metaflow/package.py

@@ -4,7 +4,6 @@
 import time
 import json
 from io import BytesIO
-from itertools import chain
 
 from .metaflow_config import DEFAULT_PACKAGE_SUFFIXES
 from .exception import MetaflowException

metaflow/pylint_wrapper.py

@@ -38,7 +38,7 @@ def run(self, logger=None, warnings=False, pylint_config=[]):
         try:
             pylint_is_happy = True
             pylint_exception_msg = ""
-            run = self._run(args, None, False)
+            self._run(args, None, False)
         except Exception as e:
             pylint_is_happy = False
             pylint_exception_msg = repr(e)

metaflow/runtime.py

@@ -5,12 +5,10 @@
 using local / remote processes
 """
 from __future__ import print_function
-import json
 import os
 import sys
 import fcntl
 import time
-import select
 import subprocess
 from datetime import datetime
 from io import BytesIO
@@ -25,8 +23,6 @@
 )
 from . import procpoll
 from .datastore import TaskDataStoreSet
-from .datastore.exceptions import DataException
-from .metadata import MetaDatum
 from .debug import debug
 from .decorators import flow_decorators
 from .mflog import mflog, RUNTIME_LOG_SOURCE