Skip to content

Commit

Permalink
don't calculate status twice
Browse files Browse the repository at this point in the history
  • Loading branch information
madhur-ob committed Dec 16, 2024
1 parent c89086d commit 1988741
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion metaflow/plugins/argo/argo_workflows_deployer_objects.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ def is_running(self):
True if the workflow status is either 'Pending' or 'Running',
False otherwise.
"""
return self.status is not None and self.status in ["Pending", "Running"]
workflow_status = self.status
return workflow_status is not None and workflow_status in ["Pending", "Running"]

@property
def status(self) -> Optional[str]:
Expand Down

0 comments on commit 1988741

Please sign in to comment.