Skip to content

Commit

Permalink
Removed retries from user-defaults.
Browse files Browse the repository at this point in the history
  • Loading branch information
valayDave committed Jul 28, 2022
1 parent 0e87a97 commit 4b2dd12
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions metaflow/plugins/airflow/airflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ def _get_retries(self, node):
parent_is_foreach = any( # The immediate parent is a foreach node.
self.graph[n].type == "foreach" for n in node.in_funcs
)

if parent_is_foreach:
max_user_code_retries + foreach_default_retry
return max_user_code_retries, max_user_code_retries + max_error_retries
Expand Down Expand Up @@ -436,7 +437,7 @@ def _to_job(self, node):
env_vars=[dict(name=k, value=v) for k, v in env.items()],
labels=labels,
task_id=node.name,
startup_timeout_seconds=60*60,
startup_timeout_seconds=60 * 60,
in_cluster=True,
get_logs=True,
do_xcom_push=True,
Expand Down Expand Up @@ -675,7 +676,6 @@ def _create_defaults(self):
# If set on a task, doesn’t run the task in the current DAG run if the previous run of the task has failed.
"depends_on_past": False,
# TODO: Enable emails
"retries": 0,
"execution_timeout": timedelta(days=5),
"retry_delay": timedelta(seconds=200),
# check https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/models/baseoperator/index.html?highlight=retry_delay#airflow.models.baseoperator.BaseOperatorMeta
Expand Down

0 comments on commit 4b2dd12

Please sign in to comment.