address feedback

Netflix · Apr 25, 2023 · 62f7089 · 62f7089
1 parent d2ecb1d
commit 62f7089
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/metaflow/plugins/argo/argo_workflows.py b/metaflow/plugins/argo/argo_workflows.py
@@ -15,6 +15,7 @@
     ARGO_EVENTS_EVENT_BUS,
     ARGO_EVENTS_EVENT_SOURCE,
     ARGO_EVENTS_SERVICE_ACCOUNT,
+    ARGO_EVENTS_WEBHOOK_URL,
     ARGO_WORKFLOWS_ENV_VARS_TO_SKIP,
     ARGO_WORKFLOWS_KUBERNETES_SECRETS,
     AWS_SECRETS_MANAGER_DEFAULT_REGION,
@@ -330,6 +331,7 @@ def _process_triggers(self):
                 "other for now."
             )
         triggers = []
+        options = None
 
         # @trigger decorator
         if self.flow._flow_decorators.get("trigger"):
@@ -981,6 +983,7 @@ def _container_templates(self):
                         "METAFLOW_ARGO_EVENTS_EVENT_BUS": ARGO_EVENTS_EVENT_BUS,
                         "METAFLOW_ARGO_EVENTS_EVENT_SOURCE": ARGO_EVENTS_EVENT_SOURCE,
                         "METAFLOW_ARGO_EVENTS_SERVICE_ACCOUNT": ARGO_EVENTS_SERVICE_ACCOUNT,
+                        "METAFLOW_ARGO_EVENTS_WEBHOOK_URL": ARGO_EVENTS_WEBHOOK_URL,
                     },
                     **{
                         # Some optional values for bookkeeping

diff --git a/metaflow/plugins/argo/argo_workflows_decorator.py b/metaflow/plugins/argo/argo_workflows_decorator.py
@@ -122,7 +122,6 @@ def task_finished(
                 name="metaflow.%s.%s"
                 % (current.get("project_flow_name", flow.name), step_name)
             )
-            event = ArgoEvent(name="metaflow.%s.%s" % (flow.name, step_name))
             # There should only be one event generated even when the task is retried.
             # Take care to only add to the list and not modify existing values.
             event.add_to_payload("id", current.pathspec)