Skip to content

Commit

Permalink
making changes sync with master
Browse files Browse the repository at this point in the history
  • Loading branch information
valayDave committed Mar 19, 2022
1 parent 5a93d9f commit 8cdac53
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions metaflow/plugins/aws/step_functions/step_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@ def _batch(self, node):
# AWS_BATCH_JOB_ATTEMPT as the job counter.
"retry_count": "$((AWS_BATCH_JOB_ATTEMPT-1))",
}

return (
Batch(self.metadata, self.environment)
.create_job(
Expand Down Expand Up @@ -737,7 +738,6 @@ def _step_cli(self, node, paths, code_package_url, user_code_retries):
param_file = "".join(
random.choice(string.ascii_lowercase) for _ in range(10)
)
# Setup Parameters as environment variables which are stored in a dictionary.
export_params = " && ".join(
[
capture_output_to_mflog(
Expand Down Expand Up @@ -807,7 +807,6 @@ def _step_cli(self, node, paths, code_package_url, user_code_retries):
if self.namespace is not None:
step.append("--namespace=%s" % self.namespace)
cmds.append(capture_output_to_mflog(" ".join(entrypoint + top_level + step)))
print("\n\n\n", cmds, "\n\n\n")
return " && ".join(cmds)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ def task_finished(
# into AWS DynamoDb so that AWS Step Functions can properly configure
# the Map job, in the absence of any better message passing feature
# between the states.
# The foreach is it's own type of Node created for stepfunctions.
if graph[step_name].type == "foreach":
# Since we can't generate the full path spec within AWS Step
# Function DynamoDb Get task, we will just key by task id for now.
Expand Down

0 comments on commit 8cdac53

Please sign in to comment.