Add error message for when if DATATOOLS_S3ROOT is None:

Netflix · Jul 25, 2023 · b89cae6 · b89cae6
1 parent ec8fd6c
commit b89cae6
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/metaflow/plugins/datatools/s3/s3.py b/metaflow/plugins/datatools/s3/s3.py
@@ -495,6 +495,10 @@ class S3(object):
 
     @classmethod
     def get_root_from_config(cls, echo, create_on_absent=True):
+        if DATATOOLS_S3ROOT is None:
+            raise MetaflowS3URLException(
+                "DATATOOLS_S3ROOT is not configured when trying to use S3 storage"
+            )
         return DATATOOLS_S3ROOT
 
     def __init__(
@@ -512,6 +516,10 @@ def __init__(
 
         if run:
             # 1. use a (current) run ID with optional customizations
+            if DATATOOLS_S3ROOT is None:
+                raise MetaflowS3URLException(
+                    "DATATOOLS_S3ROOT is not configured when trying to use S3 storage"
+                )
             parsed = urlparse(DATATOOLS_S3ROOT)
             if not bucket:
                 bucket = parsed.netloc