Add test that orig module is accessible #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
savingoyal
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Fix `._orig` access for submodules for MF extensions This addresses an issue where submodules like `mymodule._orig.submodule` would not load properly. This will properly load things like `from .foofa import xyz` from a module or sub-module in the original location but currently does not work if the import path is absolute. * Add test that orig module is accessible (#1192) * Black format Co-authored-by: Tom Furmston <tfurmston@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test that checks that the
_origmodule is accessible when a module is overwritten through extensions framework.