Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black to latest version #1199

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Update black to latest version #1199

merged 1 commit into from
Nov 28, 2022

Conversation

savingoyal
Copy link
Collaborator

No description provided.

@@ -201,7 +201,7 @@ def echo(msg, stream="stderr", batch_id=None):
if num_parallel and num_parallel > 1:
# For multinode, we need to add a placeholder that can be mutated by the caller
step_args += " [multinode-args]"
step_cli = u"{entrypoint} {top_args} step {step} {step_args}".format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of note, the removal of the "u" prefix. It should not matter since we are now 3.5+ but just pointing it out as this is technically a semantic change for some versions of Python.

Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savingoyal savingoyal merged commit 377a84b into master Nov 28, 2022
@savingoyal savingoyal deleted the black-update branch November 28, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants