Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: METAFLOW_S3_ENDPOINT_URL as a part of airflow #1368

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix: METAFLOW_S3_ENDPOINT_URL as a part of airflow #1368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metaflow/plugins/airflow/airflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
CARD_GSROOT,
DEFAULT_SECRETS_BACKEND_TYPE,
AWS_SECRETS_MANAGER_DEFAULT_REGION,
S3_ENDPOINT_URL,
)
from metaflow.parameters import DelayedEvaluationParameter, deploy_time_eval
from metaflow.plugins.kubernetes.kubernetes import Kubernetes
Expand Down Expand Up @@ -383,6 +384,7 @@ def _to_job(self, node):
# GCP stuff
"METAFLOW_DATASTORE_SYSROOT_GS": DATASTORE_SYSROOT_GS,
"METAFLOW_CARD_GSROOT": CARD_GSROOT,
"METAFLOW_S3_ENDPOINT_URL": S3_ENDPOINT_URL,
}
env[
"METAFLOW_AZURE_STORAGE_BLOB_SERVICE_ENDPOINT"
Expand Down