Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotion that labels jobs as unsafe to evict #1370

Closed
wants to merge 3 commits into from
Closed

add annotion that labels jobs as unsafe to evict #1370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e621a6
add annotation that labels jobs as unsafe to evict
Apr 25, 2023
91e5ca0
correct typo on annotation
Apr 25, 2023
7361504
Add comment (primarily to rerun failed job)
May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metaflow/plugins/kubernetes/kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,8 @@ def create_job(

(
job.annotation("metaflow/run_id", run_id)
# Prevents AWS autoscaler from targeting metaflow jobs for scaledown
.annotation("cluster-autoscaler.kubernetes.io/safe-to-evict", "false")
.annotation("metaflow/step_name", step_name)
.annotation("metaflow/task_id", task_id)
.annotation("metaflow/attempt", attempt)
Expand Down