Fix an issue introduced in 2.8.4 that prevented pickled MetaflowObjec… #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from being accessed after pickling in a different namespace The core issue is that we now call the constructor when un-pickling which will recheck the namespace. This broke previous behavior where the constructor was not called and no namespace check was done
pjoshi30
reviewed
May 5, 2023
| # Note that we set _namespace_check to False because we want the user to | ||
| # be able to access this object even after unpickling it. If we set it to | ||
| # True, it would check the namespace again at the time of unpickling even | ||
| # if the user properly got the object in the first place and pickled it. | ||
| return { | ||
| "version": "2.8.4", |
There was a problem hiding this comment.
this will still be a problem with older versions that do not understand this new dictionary format. how do we handle that case? One option is to not use this custom dictionary format using a version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t from being accessed after pickling in a different namespace
The core issue is that we now call the constructor when un-pickling which will recheck the namespace. This broke previous behavior where the constructor was not called and no namespace check was done