feat: ability to use ServerSideEncryption for S3 uploads #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikonen
approved these changes
Jun 8, 2023
saikonen
requested changes
Jun 8, 2023
There was a problem hiding this comment.
looks good and works as intended. Could you run the PR through Black formatting so the pre-commit step passes as well?
There are some details about the pre-commit tooling here:
https://github.com/Netflix/metaflow/blob/master/CONTRIBUTING.md#code-style
saikonen
approved these changes
Jun 14, 2023
|
@saikonen just wondering if anything else is needed from our side before we can get this merged, not sure if those failing checks are a blocker? Let us know if you need anything! |
|
All good, sorry for taking a while to get to these :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to enable Server-Side Encryption (SSE) for S3 uploads through the use of the
METAFLOW_S3_SERVER_SIDE_ENCRYPTIONconfiguration setting.See this PR for prior conversations regarding the topic.