Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly ignore a duplicate metaflow extension package in sys.path #1437

Merged
merged 1 commit into from
May 31, 2023
Merged

Properly ignore a duplicate metaflow extension package in sys.path #1437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions metaflow/extension_support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,19 +384,24 @@ def _get_extension_packages():
if any(
[pkg == EXT_PKG for pkg in (dist.read_text("top_level.txt") or "").split()]
):
# In all cases (whether duplicate package or not), we remove the package
# from the list of locations to look in.
# This is not 100% accurate because it is possible that at the same
# location there is a package and a non-package, but this is extremely
# unlikely so we are going to ignore this case.
dist_root = dist.locate_file(EXT_PKG).as_posix()
all_paths.discard(dist_root)

if dist.metadata["Name"] in mf_ext_packages:
_ext_debug(
"Ignoring duplicate package '%s' (duplicate paths in sys.path? (%s))"
% (dist.metadata["Name"], str(sys.path))
)
continue
_ext_debug("Found extension package '%s'..." % dist.metadata["Name"])

# Remove the path from the paths to search. This is not 100% accurate because
# it is possible that at that same location there is a package and a non-package,
# but it is exceedingly unlikely, so we are going to ignore this.
dist_root = dist.locate_file(EXT_PKG).as_posix()
all_paths.discard(dist_root)
_ext_debug(
"Found extension package '%s' at '%s'..."
% (dist.metadata["Name"], dist_root)
)

files_to_include = []
meta_module = None
Expand Down