-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds custom annotations via env variables #1442
Conversation
@savingoyal or @shrinandj could you take a look when you have a moment? |
Took this for a spin and it is working as intended for the Kubernetes side. Also applies custom annotations first so does not make it possible to override system annotations (f.ex. Small question though, as the original discussion was focused on the |
@saikonen Agreed that it makes sense to have argo included in this PR. I just added it in the recent commit and it's ready for your review |
Testing[445] @ 86f1412 |
…tom-annotations-with-labels-refactor
…abels-refactor Merge label-refactor branch and refactor the annotations into kubernetes decorator
@savingoyal Could you merge this when you have a moment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved! i will make this part of the next release.
This reverts commit f8861b8.
Implementation of the work described here: #1370
Adds the ability to add custom annotations to the kubernetes jobs via an environment variable