Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds custom annotations via env variables #1442

Merged
merged 17 commits into from
Jul 27, 2023

Conversation

tylerpotts
Copy link
Contributor

@tylerpotts tylerpotts commented Jun 6, 2023

Implementation of the work described here: #1370

Adds the ability to add custom annotations to the kubernetes jobs via an environment variable

@tylerpotts
Copy link
Contributor Author

tylerpotts commented Jun 6, 2023

@savingoyal or @shrinandj could you take a look when you have a moment?

@savingoyal savingoyal requested a review from saikonen June 12, 2023 16:51
@saikonen
Copy link
Collaborator

Took this for a spin and it is working as intended for the Kubernetes side. Also applies custom annotations first so does not make it possible to override system annotations (f.ex. metaflow/*) as expected 👍

Small question though, as the original discussion was focused on the safe-to-evict control annotation, but now we're introducing arbitrary annotations, do we want this to work with Argo Workflows as well? Currently there is no setup for the custom annotations for Argo Workflows, so that could still be added (similar to how labels are treated in argo_workflows.py).

@tylerpotts
Copy link
Contributor Author

@saikonen Agreed that it makes sense to have argo included in this PR. I just added it in the recent commit and it's ready for your review

metaflow/plugins/kubernetes/kubernetes.py Show resolved Hide resolved
metaflow/plugins/kubernetes/kubernetes.py Outdated Show resolved Hide resolved
metaflow/plugins/argo/argo_workflows.py Outdated Show resolved Hide resolved
metaflow/plugins/argo/argo_workflows.py Outdated Show resolved Hide resolved
metaflow/plugins/kubernetes/kubernetes.py Outdated Show resolved Hide resolved
@nflx-mf-bot
Copy link
Collaborator

Testing[445] @ 86f1412

saikonen
saikonen previously approved these changes Jul 12, 2023
@tylerpotts
Copy link
Contributor Author

@savingoyal Could you merge this when you have a moment?

Copy link
Collaborator

@savingoyal savingoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! i will make this part of the next release.

@savingoyal savingoyal merged commit f8861b8 into Netflix:master Jul 27, 2023
savingoyal added a commit that referenced this pull request Aug 29, 2023
savingoyal added a commit that referenced this pull request Aug 29, 2023
saikonen added a commit that referenced this pull request Oct 4, 2023
saikonen added a commit that referenced this pull request Oct 12, 2023
saikonen added a commit that referenced this pull request Oct 12, 2023
saikonen added a commit that referenced this pull request Jan 15, 2024
saikonen added a commit that referenced this pull request Mar 18, 2024
saikonen added a commit that referenced this pull request Apr 29, 2024
saikonen added a commit that referenced this pull request Nov 18, 2024
saikonen added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants