Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/kubernetes decorator docstring #1562

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix/kubernetes decorator docstring #1562

merged 1 commit into from
Oct 4, 2023

Conversation

tfurmston
Copy link
Contributor

@tfurmston tfurmston commented Oct 1, 2023 •
edited
Loading

This PR does the following:

  • Adds some missing arguments to the docstring for the Kubernetes decorator class, including gpu, gpu_vendor & image_pull_policy.
  • Order the docstring arguments to be consistent with the ordering of the arguments to the decorator.

Note: The node_selector argument is still missing a docstring. I wasn't 100% sure on the different possible options for specifying this argument, so I left this one from the PR.

@savingoyal savingoyal merged commit 8c8ecc8 into Netflix:master Oct 4, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfurmston @savingoyal