Make Kubernetes default resources configurable #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested locally by doing I tested setting |
saikonen
requested changes
May 2, 2024
|
@saikonen , changes ready for your review! |
saikonen
requested changes
May 3, 2024
saikonen
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1769.
A quick addition that looks if the METAFLOW_KUBERNETES_CPU, METAFLOW_KUBERNETES_MEMORY, METAFLOW_KUBERNETES_DISK environment variable is set and if so parses the values. If a value is detected as being an attribute, then assign it, otherwise it will just use the default values as defined.