feature: backwards compatible Kubernetes list and kill #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
previously approved these changes
Sep 11, 2024
* add fallbacks to kube kill * block killing pods managed by argo-workflows
savingoyal
reviewed
Sep 11, 2024
savingoyal
reviewed
Sep 16, 2024
| # Metaflows Kubernetes job names are of the format | ||
| # t-{uid}-{k8s_job_generate_name_suffix}-{k8s_pod_generate_name_suffix} | ||
| # so we can infer the job name from the pod name by dropping the last suffix | ||
| job_name = "-".join(pod.metadata.name.split("-")[:-1]) |
There was a problem hiding this comment.
could we get this from pod's owner reference instead?
There was a problem hiding this comment.
seems so, or upon further inspection its also part of the pod labels as well so I'll go with that as the simplest source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1998 as the first attempt, as this approach is backwards compatible.
closes #1631
caveat
this approach iterates through all active pods in a namespace indiscriminately (with a limit of
1000per request), only filtering on the client side for relevant ones. As a result, in deployments with enormous amounts of active pods, the operation can take quite long.