Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail early without needing to reduce file_read_timeout #2180

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

madhur-ob
Copy link
Collaborator

context:

consider the flow at f.py

from metaflow import FlowSpec, kubernetes, step, current, project, Flow
import os, time

class HelloFlow(FlowSpec):

    @step
    def start(self):
        x.foo()
        self.next(self.end)

    @step
    def end(self):
        print('value is', self.model)

if __name__ == '__main__':
    HelloFlow()

and consider using it with:

from metaflow import Runner

with Runner('./f.py').run() as running:
    print('done')

the runner gets stuck after merging of #2169

if we try the following, it exits when the timeout passes...

from metaflow import Runner

with Runner('./f.py', file_read_timeout=10).run() as running:
    print('done')

since the default is 3600 secs, we should exit early..

Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savingoyal savingoyal merged commit ca24277 into Netflix:master Dec 16, 2024
29 checks passed
@madhur-ob madhur-ob deleted the check-for-failure branch December 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants