[heartbeats] Better error handling #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
valayDave
commented
Jan 2, 2025
•
valayDave
commented
- Ensure better error handling so that any server related flakiness can be handled without crashing the heartbeat thread.
- If the heartbeat thread crashes because of any server issues / DNS issues / Intermittent server flakiness, it will kill the heartbeat thread causing the UI to mark the run as failed.
- This change ensures that we don't crash the thread an makes it exponentially backoff calling the server.
valayDave
changed the title
- Ensure better error handling so that any server related flakiness can be handled without crashing the heartbeat thread.
valayDave
force-pushed
the
valayoss/hb-fix
branch
from
678a340 to
b4b1425
Compare
valayDave
changed the title
savingoyal
reviewed
Jan 4, 2025
| response = requests.post( | ||
| url=self.hb_url, data="{}", headers=self.headers.copy() | ||
| ) | ||
| try: |
There was a problem hiding this comment.
should we change time.sleep(4**retry_counter) to be less aggressive? It is likely that the UI may still mark the task as failed, given how aggressively the sleep value grows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.