Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the first environments directory instead of conda_prefix #282

Merged

Conversation

sodre
Copy link
Contributor

@sodre sodre commented Aug 13, 2020

The conda_prefix folder is not always writable, so creating a lock there can fail.
On the other hand, conda's first entry in "envs_dirs" should always be writable.

Fix #179

The conda_prefix folder is not always writable, so creating a lock there can fail.
On the other hand, conda's first entry in "envs_dirs" should always be writable.

Fix Netflix#179
@sodre sodre changed the title Use the first environs dir instead of conda_prefix Use the first environments directory instead of conda_prefix Aug 14, 2020
@sodre sodre marked this pull request as ready for review August 14, 2020 01:47
Copy link
Collaborator

@savingoyal savingoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romain-intel
Copy link
Contributor

Perfect! This was the fix I had in mind. We can investigate if we need the lock but this is perfect for now :).

@savingoyal savingoyal merged commit ad313c0 into Netflix:master Aug 17, 2020
@sodre sodre deleted the issue/179-directory-permission-error branch August 18, 2020 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission error when running tutorial episode 04
3 participants