Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker registry parsing for AWS Batch decorator #62

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Fix docker registry parsing for AWS Batch decorator #62

merged 1 commit into from
Dec 16, 2019

Conversation

savingoyal
Copy link
Collaborator

re.search instead of re.match to disambiguate between valid docker
registry urls

@savingoyal
Fix docker registry parsing for AWS Batch decorator
e13cef7 
re.search instead of re.match to disambiguate between valid docker
registry urls
romain-intel
romain-intel approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savingoyal savingoyal merged commit 80e4546 into master Dec 16, 2019
@savingoyal savingoyal deleted the docker branch December 19, 2019 01:59
@savingoyal
Copy link
Collaborator Author

@Shago7939 Could you elaborate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-intel romain-intel romain-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savingoyal @romain-intel