Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit project related tags from within project decorator #695

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Emit project related tags from within project decorator #695

merged 2 commits into from
Sep 10, 2021

Conversation

savingoyal
Copy link
Collaborator

No description provided.

romain-intel
romain-intel requested changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datastore will need the metadata in the convergence branch to pass it down to the task datastores.

@savingoyal
Copy link
Collaborator Author

The datastore will need the metadata in the convergence branch to pass it down to the task datastores.

Resolved offline that this change is independent of metadata being referenced in datastore.

@savingoyal savingoyal merged commit 2f15f43 into master Sep 10, 2021
@savingoyal savingoyal deleted the tags-fix branch September 10, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-intel romain-intel romain-intel requested changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savingoyal @romain-intel