Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from metaflow.sidecar_messages import Message for line 13 #718

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 24, 2021

An undefined name in a type hint.

As done at https://github.com/Netflix/metaflow/blob/master/metaflow/plugins/debug_monitor.py#L5 for line 27.

$ BUILTINS=assert_equals,assert_exception,inputs,is_resumed,NUM_FOREACH,NUM_LINES,ResumeFromHere,TestRetry
$ flake8 . --builtins=$BUILTINS --count --select=E9,F63,F7,F82 --show-source --statistics

./metaflow/metaflow/plugins/debug_logger.py:11:9: F821 undefined name 'Message'
        # type: (Message) -> None
        ^

As done at https://github.com/Netflix/metaflow/blob/master/metaflow/plugins/debug_monitor.py#L5

$ `BUILTINS=assert_equals,assert_exception,inputs,is_resumed,NUM_FOREACH,NUM_LINES,ResumeFromHere,TestRetry`
$ `flake8 . --builtins=$BUILTINS --count --select=E9,F63,F7,F82 --show-source --statistics`
```
./metaflow/metaflow/plugins/debug_logger.py:11:9: F821 undefined name 'Message'
        # type: (Message) -> None
        ^
```
Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romain-intel romain-intel merged commit 1898813 into Netflix:master Sep 30, 2021
@cclauss cclauss deleted the patch-1 branch September 30, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants