Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with current.paramter_names #731

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Fix bug with current.paramter_names #731

merged 3 commits into from
Oct 2, 2021

Conversation

savingoyal
Copy link
Collaborator

Without this patch, the following flow returns an empty list for parameter_names -

from metaflow import FlowSpec,Parameter,step

class ParameterNameFlow(FlowSpec):

    x = Parameter('x',default=3,type=int)

    @step
    def start(self):
        from metaflow import current
        print(current.parameter_names)
        self.next(self.end)

    @step
    def end(self):
        print("Done Compute")

if __name__ == "__main__":
    ParameterNameFlow()

Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can add the test flow as discussed if you want and merge.

@savingoyal savingoyal merged commit 320b8a9 into master Oct 2, 2021
@savingoyal savingoyal deleted the current-fix branch October 2, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants