Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #589: validation logic to capture reserved keywords #830

Merged
merged 5 commits into from
Jan 3, 2022
Merged

Fixes #589: validation logic to capture reserved keywords #830

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccbaedd
added validation list
0xrushi Nov 20, 2021
70cce8d
added validation list
0xrushi Nov 20, 2021
bfe0d10
some more params
0xrushi Dec 4, 2021
4d0b775
black formatting
0xrushi Dec 6, 2021
9b079cd
Merge branch 'master' into validation_logic_to_capture_reserved_#589
0xrushi Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions metaflow/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,21 @@ def __init__(self, name, **kwargs):
self.kwargs = kwargs
# TODO: check that the type is one of the supported types
param_type = self.kwargs["type"] = self._get_type(kwargs)

if self.name == "params":
reserved_params = [
"params",
"with",
"max-num-splits",
"max-workers",
"tag",
"run-id-file",
"namespace",
]

if self.name in reserved_params:
raise MetaflowException(
"Parameter name 'params' is a reserved "
"Parameter name '%s' is a reserved "
"word. Please use a different "
"name for your parameter."
"name for your parameter." % (name)
)

# make sure the user is not trying to pass a function in one of the
Expand Down