fix argument type handling for host_volumes when used with --with and SFN #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
There is a somewhat obscure difference in a way list attributes are handled between SFN and "standalone" AWS Batch. If the attribute is a list of strings, but the user passes a single string instead, it is implicitly converted to a single-item list when we convert attributes to command-line args for
batch_cli.pyand they are parsed back to Python objects byclick. However, that conversion does not happen when used with SFN.Short term fix
Support both single strings and lists for
host_volumesA longer term fix
A proper solution would be to more explicitly support list attributes in decospec parser used for
--with, and have unit tests for that. Right now it just kinda happens to (mostly) work.