Skip to content

Commit

Permalink
fix(adapter-puppeteer): Remove other resource type matching
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonmit committed Apr 9, 2019
1 parent 47a90b7 commit 263a867
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 3 deletions.
14 changes: 14 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ This will bootstrap & build the packages, stand up the node test server, and
instantiate testem. Once running, the test suite will be rerun when any changes
are made to the src or test files.

## Running Node Tests with Node/Chrome Inspector

To run the node test suite with node inspector support, run from the root directory:

```bash
yarn test:ci -l Node:debug
```

## Running Docs

All the documentation can be found in the root level `docs` directory. Running
Expand All @@ -50,6 +58,12 @@ changes.
yarn docs:serve
```

## Debugging Node Modules

It's common to be able to attach a debugging while triaging or building out a Node feature.

We've

## Conventional Commits

Lerna depends on the use of the [Conventional Commits Specification](https://conventionalcommits.org/)
Expand Down
2 changes: 2 additions & 0 deletions docs/adapters/puppeteer.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ you to get the full power of Polly and Puppeteer.

## Installation

?> **NOTE** If you're using Puppeteer 1.7 or 1.8, you'll experience issues using passthrough requests. Please upgrade to the latest version of Puppeteer or use a version prior to 1.7.

_Note that you must have node (and npm) installed._

```bash
Expand Down
2 changes: 2 additions & 0 deletions packages/@pollyjs/adapter-puppeteer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ to be used with `@pollyjs/core`.

## Installation

_If you're using puppeteer 1.7 or 1.8, you'll experience issues with passthrough requests. Please upgrade to the latest version of puppeteer or use a version prior to 1.7_

_Note that you must have node (and npm) installed._

```bash
Expand Down
4 changes: 1 addition & 3 deletions packages/@pollyjs/adapter-puppeteer/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ export default class PuppeteerAdapter extends Adapter {
get defaultOptions() {
return {
page: null,

/* NOTE: `"other" is needed as of puppeteer 1.7.0 to capture the passthrough request */
requestResourceTypes: ['xhr', 'fetch', 'other']
requestResourceTypes: ['xhr', 'fetch']
};
}

Expand Down
4 changes: 4 additions & 0 deletions testem.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ module.exports = {
},
middleware: [attachMiddleware],
launchers: {
'Node:debug': {
command: 'yarn test:node --reporter tap --inspect-brk',
protocol: 'tap'
},
Node: {
command: 'yarn test:node --reporter tap',
protocol: 'tap'
Expand Down

0 comments on commit 263a867

Please sign in to comment.