fix: Handle failed arraybuffer instanceof checks #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
commented
Jun 2, 2021
| !(arrayBuffer instanceof ArrayBuffer) && | ||
| 'byteLength' in arrayBuffer | ||
| ) { | ||
| arrayBuffer = cloneArrayBuffer(arrayBuffer); |
There was a problem hiding this comment.
The alternative here is to do something like arrayBuffer.__proto__ = ArrayBuffer.prototype but that feels very flakey
There was a problem hiding this comment.
The pro to just changing the proto is that we won't need to clone the array buffer at all
offirgolan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When context is provided to both the XHR and Fetch adapters, the arraybuffers that are created by the responses don't pass Buffer.from's instanceof check. To get around that (for now), we clone the ArrayBuffer which uses the same constructor that Buffer.from expects.
Motivation and Context
Resolves #388.
Types of Changes
Checklist