Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update types for class methods #438

Merged
merged 1 commit into from
Dec 10, 2021
Merged

fix: Update types for class methods #438

merged 1 commit into from
Dec 10, 2021

Conversation

redabacha
Copy link
Contributor

Motivation and Context

the class method types defined currently do not work well when trying to extend a class for a custom adapter and create a lot of typescript errors. this is because some of the types are defined as class properties with anonymous functions rather than actual class methods.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan
Copy link
Collaborator

Thanks for the PR!

@offirgolan offirgolan merged commit b88655a into Netflix:master Dec 10, 2021
@offirgolan
Copy link
Collaborator

Released with v6.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants