Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Age Gauge and Monotonic Counter meter types #75

Merged
merged 1 commit into from
May 7, 2024

Conversation

copperlight
Copy link
Collaborator

Also, swap all meterTypeSymbols to string, for consistency.

Also, swap all `meterTypeSymbols` to `string`, for consistency.
@copperlight copperlight requested a review from jivimberg May 7, 2024 22:37
// has successfully occurred, or 0 to use the current time in epoch seconds. After an Age Gauge
// has been set, it will continue reporting the number of seconds since the last time recorded,
// for as long as the spectatord process runs. The purpose of this metric type is to enable users
// to more easily implement the Time Since Last Success alerting pattern.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no atlas-docs on this meter type, so I just inlined the spectatord description.

// in order for spectatord to calculate a delta value and report it to the backend.
//
// A variety of networking metrics may be reported monotonically and this metric type provides a
// convenient means of recording these values, at the expense of a slower time-to-first metric.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no atlas-docs on this meter type, so I just inlined the spectatord description.

Copy link
Contributor

@jivimberg jivimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@copperlight copperlight merged commit db721a8 into Netflix:main May 7, 2024
2 checks passed
@copperlight copperlight deleted the additional-meter-types branch September 27, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants