Renaming RegistryInterface to Registry and hiding impl details #88
Conversation
spectator/registry.go
Outdated
| logger logger.Logger | ||
| loggerMutex sync.RWMutex | ||
| } | ||
|
|
||
| // NewRegistryConfiguredBy loads a new Config JSON file from disk at the path specified. | ||
| func NewRegistryConfiguredBy(filePath string) (*Registry, error) { | ||
| func NewRegistryConfiguredBy(filePath string) (Registry, error) { |
There was a problem hiding this comment.
Hmm, if you updated this signature to take an optional logger argument and then assigned that to the config, it would obviate the need for a mutable logger on the Registry itself, further simplifying that interface.
| func NewRegistryConfiguredBy(filePath string) (Registry, error) { | |
| func NewRegistryConfiguredBy(filePath string, logger Logger) (Registry, error) { |
There was a problem hiding this comment.
Removed the option to create a Registry from a file-based config. Thanks for the recommendation 🙌
There was a problem hiding this comment.
Nice, this should let you shrink surface area of the registry interface too!
…on. Removed SetLogger function from Registry API
I think it's already there: https://github.com/Netflix/spectator-go/blob/main/README.md?plain=1#L132 |
Whoops, I lost track of it in the diffs. Thank you! |
Renamed
RegistryInterfacetoRegistry.Reduced visibility for
spectatordRegistry.Meant to reduce library API.