-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFmpeg VMAF v1.3.5 - Segfault #177
Comments
Investigating. Thanks for the report. |
the libvmaf support for ffmpeg is broken from VDK 1.3.5 onwards, 1.3.5 you are able to compile ffmpeg with libvmaf support but when trying to use it it gives a segmentation fault and ffmpeg doesn't compile with VDK 1.3.6 and 1.3.7, the last working version of libvmaf is 1.3.4. According to the ffmpeg developers the API has changed in VDK 1.3.5 onwards. |
I have reverted to use libvmaf 1.3.4 with ffmpeg 4.0.2 according to your discussion. Can anybody give some light on this? Thanks! |
Hi @RonLu, It works correctly for me with FFmpeg 4.0.2 and VMAF 1.3.4. You can use my build process if you'd like, see: If it doesn't work for you, I suggest you run it with GDB and provide the full backtrace. |
Hi @jessp01, Program received signal SIGSEGV, Segmentation fault. I checked the vf_libvmaf.c in the source code I download, it looks like it does't include the fix 51775bc1cdeff04b836422be66e8098146aedcce (avfilter/vf_libvmaf: the libvmaf filter tried to join on an invalid t…) which was committed on 30 Apr. But the source code is from ffmpeg 4.0.2 version which was released on July 18th. Why it doesn't include the change on 30 Apr? |
Hi @RonLu, That's a different problem, obviously, so I would suggest opening a separate issue for it and attaching the BT. |
Hi @jessp01, |
Hi @kylophone, |
Also, @kylophone, please look at the different BTs and descriptions. @RonLu's issue is different to mine. @RonLu - as per your question, FFmpeg's bug tracker is here https://trac.ffmpeg.org |
Hi @kylophone, This patch with VMAF 1.3.9 resolves the issue. |
Cool. Thanks. |
Cheers, @kylophone. If anyone is interested, I now apply the patch in my project here: |
Hello VMAF team,
When linking FFmpeg against libvmaf.a built from 1.3.5, the following results in a segfault:
This works correctly with v1.3.4.
If you need a full reproduction, please use https://gitlab.com/jessp011/fully-static-ffmpeg-build.
Simply edit https://gitlab.com/jessp011/fully-static-ffmpeg-build/blob/master/env.rc#L20 and build.
This repo also includes the test MP4 file:
https://gitlab.com/jessp011/fully-static-ffmpeg-build/blob/master/test/big_buck.mp4
Full backtrace:
Also, v1.3.6rc and v1.3.7rc cannot be used due this commit:
1b0f6ef#diff-fa18e21ed0ed7b3f769ceab3d86c7e3aR28
Because FFmpeg uses a C compiler and not a C++ one [in my case GCC], it will fail with:
Thanks,
The text was updated successfully, but these errors were encountered: