Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_run_kfold_cross_validation_with_list_input fails on Fedora 23 #1

Closed
tdaede opened this issue Jun 7, 2016 · 10 comments
Closed

Comments

@tdaede
Copy link

tdaede commented Jun 7, 2016

FAIL: test_run_kfold_cross_validation_with_list_input (cross_validation_test.FeatureCrossValidationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/thomas/sandbox/vmaf/python/test/cross_validation_test.py", line 92, in test_run_kfold_cross_validation_with_list_input
    self.assertAlmostEquals(output['aggr_stats']['SRCC'], 0.90636761259756715, places=4)
AssertionError: 0.90647090523758211 != 0.9063676125975672 within 4 places

The value is off just a little too much for places=4. How much variance is expected here?

@li-zhi
Copy link
Collaborator

li-zhi commented Jun 7, 2016

Hi Tdaede, there could be several possibilities: 1) If the numpy/scipy/sklearn are not up-to-date, there could be numeric differences. You can follow the Prerequiste/Troubleshooting section for this. 2) I also found that there could be numeric difference across platforms. I have not tried on Fedora. I could definitely look into a Fedora to see if the result makes sense or not. Is this the only failed test case?

@haiqianw
Copy link

haiqianw commented Jun 7, 2016

Hi Zhi,

I am Haiqiang Wang from USC. Currently I work with Ioannis on the project.

I pulled it from Git yesterday. All the prerequisite (numpy, scipy,
sklearn) were installed with correct version, but I encountered the same
FAIL as Thomas, it is the only failure that happened. My platform is Mac
pro El Capitan 10.11.

Best,
Haiqiang

On Tue, Jun 7, 2016 at 12:51 PM, Zhi Li notifications@github.com wrote:

Hi Tdaede, there could be several possibilities: 1) If the
numpy/scipy/sklearn are not up-to-date, there could be numeric differences.
You can follow the Prerequiste/Troubleshooting section for this. 2) I also
found that there could be numeric difference across platforms. I have not
tried on Fedora. I could definitely look into a Fedora to see if the result
makes sense or not. Is this the only failed test case?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Netflix_vmaf_issues_1-23issuecomment-2D224394049&d=DQMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=6qctLIgM3vp75AehAaBacw&m=0D2L7TG714unv2aRMQ1mksIhrhdZSkaCoeQn1Soa3VM&s=kNUWKEaKIY_snd2-PEmxKb3rUQk54dQQwjiXldrVZxc&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe_APd647kdkDuC8gDqMe5m9nUevQrxev9dks5qJcvZgaJpZM4IwRqm&d=DQMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=6qctLIgM3vp75AehAaBacw&m=0D2L7TG714unv2aRMQ1mksIhrhdZSkaCoeQn1Soa3VM&s=WXXvR3fI2XRujoWs-nkLP9kwCmE2ibmUMR_4UVPWSOE&e=
.

@tdaede
Copy link
Author

tdaede commented Jun 7, 2016

I realized that Fedora 23's versions of all the packages were out of date from those listed. I made a virtualenv and installed the versions listed, but still got the exact same result.

Maybe it's a difference in BLAS implementation or something? I'm using atlas 3.10.2.

@li-zhi
Copy link
Collaborator

li-zhi commented Jun 7, 2016

Hi Haiqiang, just want to make sure you were directly building in Mac OS, not on a Fedora VM, right?

@haiqianw
Copy link

haiqianw commented Jun 7, 2016

Yes, directly in Mac OS.

@li-zhi
Copy link
Collaborator

li-zhi commented Jun 8, 2016

@tdaede: I was able to reproduce your issue on Fedora 23 (I noticed the atlas version was atlas-3.10.2-6.fc23.x86_64 when installing numpy). After upgrading numpy/scipy/sklearn/matplotlib/pandas (pip install --upgrade xxx), the issue went away.

@haiqianw: I tried it on El Capitan, but was unable to reproduce it.

I suspect it is still issue of package out of date. When you check the package version, please try to use:

python -c 'import numpy as pkg; print pkg.version; print pkg.file'
python -c 'import scipy as pkg; print pkg.version; print pkg.file'
python -c 'import matplotlib as pkg; print pkg.version; print pkg.file'
python -c 'import pandas as pkg; print pkg.version; print pkg.file'
python -c 'import sklearn as pkg; print pkg.version; print pkg.file'

instead of 'pip freeze'. Sometimes they can give you different results.

@haiqianw
Copy link

haiqianw commented Jun 8, 2016

python -c 'import numpy as pkg; print pkg.version; print pkg.file'

<module 'numpy.version' from '/Users/Haiqiang/anaconda/lib/python2.7/site-packages/numpy/version.pyc'> Traceback (most recent call last): File "<string>", line 1, in <module> AttributeError: 'module' object has no attribute 'file'

If I check the package version following README
1.10.4 /Users/Haiqiang/anaconda/lib/python2.7/site-packages/numpy/__init__.pyc
0.17.0 /Users/Haiqiang/anaconda/lib/python2.7/site-packages/scipy/__init__.pyc
1.5.1 /Users/Haiqiang/anaconda/lib/python2.7/site-packages/matplotlib/__init__.pyc
0.18.0 /Users/Haiqiang/anaconda/lib/python2.7/site-packages/pandas/__init__.pyc
0.17.1 /Users/Haiqiang/anaconda/lib/python2.7/site-packages/sklearn/__init__.pyc

The only difference with README is about pandas, which required >=0.17.1

@li-zhi
Copy link
Collaborator

li-zhi commented Jun 8, 2016

@haiqianw: from your output, I realize that you are using the anaconda installation. It's an known issue to me that some test cases will fail under anaconda (it seems to be an artifact with their bake). I would recommend not to use anaconda but simply use pip.

@tdaede
Copy link
Author

tdaede commented Jun 9, 2016

In a Fedora 23 VM with blas and lapack but no atlas, all unit tests pass. So it seems like this is due to one of the dependencies using atlas instead. I'll walk through each one and see if I can find the offending package.

@li-zhi
Copy link
Collaborator

li-zhi commented Jun 10, 2016

Thanks! Let me know if you find anything and I'll put some notes in the troubleshoot section.

@li-zhi li-zhi closed this as completed Sep 7, 2016
li-zhi added a commit that referenced this issue Dec 14, 2016
li-zhi pushed a commit that referenced this issue Feb 14, 2019
Updating to the latest master branch
IttiamVijayakumarGR added a commit to IttiamVijayakumarGR/vmaf that referenced this issue May 8, 2020
Consolidate, clean up, minor optimizations - By Kyle
IttiamVijayakumarGR added a commit to IttiamVijayakumarGR/vmaf that referenced this issue May 15, 2020
- Code modification based on understanding from MotionScore and VIF review
- Addition of function macros for code consolidation
- Performance optimsations with modifications of integer arithmetic logic
foosoftsrlold added a commit to foosoftsrl/vmaf that referenced this issue Nov 19, 2021
JacksonDagger pushed a commit to JacksonDagger/PIM-vmaf that referenced this issue May 4, 2022
…addBasicStatsToResult to master

* commit '816fed90a27c216d5ed41dafb0d0bd6c40dcb298':
  Changing dict to list in stats
  Adding stats script
  Adding total variation and moving average. Need to add more tests
  Adding basic stats to Result class
nilfm99 pushed a commit that referenced this issue Jul 9, 2024
Adjust the order and format of inputs to libvmaf_cuda  according to https://ffmpeg.org/ffmpeg-filters.html#toc-libvmaf_005fcuda


The libvmaf_cuda filter allows only AV_FIX_FMT_CUDA(sw NV12) (https://github.com/FFmpeg/FFmpeg/blob/master/libavfilter/vf_libvmaf.c#L821C26-L821C41). So the current code raises 'Unsupported input format: nv12' like below

```
Stream mapping:
  Stream #0:0 (h264) -> libvmaf_cuda
  Stream #1:0 (h264) -> libvmaf_cuda
  libvmaf_cuda:default -> Stream #0:0 (wrapped_avframe)
Press [q] to stop, [?] for help
[libvmaf @ 0x7f95d00050c0] Unsupported input format: nv12
[Parsed_libvmaf_cuda_0 @ 0x7f95d0004fc0] Failed to configure output pad on Parsed_libvmaf_cuda_0
[fc#0 @ 0x55b0b17da800] Error reinitializing filters!
[fc#0 @ 0x55b0b17da800] Task finished with error code: -22 (Invalid argument)
[fc#0 @ 0x55b0b17da800] Terminating thread with return code -22 (Invalid argument)
[vost#0:0/wrapped_avframe @ 0x55b0b181a8c0] Could not open encoder before EOF
[vost#0:0/wrapped_avframe @ 0x55b0b181a8c0] Task finished with error code: -22 (Invalid argument)
[vost#0:0/wrapped_avframe @ 0x55b0b181a8c0] Terminating thread with return code -22 (Invalid argument)
[out#0/null @ 0x55b0b181be80] Nothing was written into output file, because at least one of its streams received no packets.
frame=    0 fps=0.0 q=0.0 Lsize=       0KiB time=N/A bitrate=N/A speed=N/A

Conversion failed!
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants