Partially fix score difference for CUDA (bpc >=10) #1195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift in scale 0 used to assume bit depth of 16, this is now variable. A typo in the call to adm_dwt2_16_device caused i4_ref_dwt2 not to be written.
|
@MorkTheOrk can you please rebase this to master? I see changes to more than just vif. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly lowers score difference on CUDA for high bit images.
VMAF score for 1000 frames of a 4096x2160 10bpc sequence in FFMPEG:
with libvmaf_cuda (GPU):
[Parsed_libvmaf_cuda_0 @ 0x559ffac22b00] VMAF score: 76.101209with libvmaf (CPU):
[Parsed_libvmaf_2 @ 0x55a7e344cf80] VMAF score: 76.101269Score difference is now dependet on the sequence used.