Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github/workflows/libvmaf.yml: upload to a specific name for each matrix.oss and matrix.cc #1322

Merged
merged 1 commit into from
Feb 8, 2024
Merged

github/workflows/libvmaf.yml: upload to a specific name for each matrix.oss and matrix.cc #1322

merged 1 commit into from
Feb 8, 2024

Conversation

nilfm99
Copy link
Collaborator

@nilfm99 nilfm99 commented Jan 30, 2024 •
edited
Loading

Should fix #1278 and unblock #1292

@nilfm99
Copy link
Collaborator Author

nilfm99 commented Jan 31, 2024

on second thought, to fix #1278 we also need to fix the actions/upload-release-asset@v1 step

@nilfm99 nilfm99 marked this pull request as draft January 31, 2024 21:06
@nilfm99
Copy link
Collaborator Author

nilfm99 commented Feb 8, 2024

I think this still makes sense to merge to unblock #1292, and then we can think how to solve #1278. The action we use to upload release assets has been archived and the README suggests using a newer one, we can look into that.

@nilfm99 nilfm99 marked this pull request as ready for review February 8, 2024 16:11
@nilfm99 nilfm99 merged commit 8a57e3e into master Feb 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails on every release
1 participant
@nilfm99