Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: pin numpy to <2.0.0 #1372

Merged
merged 1 commit into from
Jun 20, 2024
Merged

requirements.txt: pin numpy to <2.0.0 #1372

merged 1 commit into from
Jun 20, 2024

Conversation

nilfm99
Copy link
Collaborator

@nilfm99 nilfm99 commented Jun 20, 2024

Some of our python code is broken by the numpy v2.0.0 changes. Namely, printing numpy float values is now different:

  • in numpy 1.x:
>>> a = {"a": np.float64(3.2)}
>>> print(a)
{'a': 3.2}
  • in numpy 2.x:
>>> a = {"a": np.float64(3.2)}
>>> print(a)
{'a': np.float64(3.2)}

This doesn't play well with the ast.literal_eval-based parsing that we use. Longer term, we should get rid of ast.literal_eval and use JSON.

@nilfm99 nilfm99 requested a review from christosbampis June 20, 2024 16:44
@nilfm99 nilfm99 merged commit 8cc78af into master Jun 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant