Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Add libvmaf.yml #558

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Actions: Add libvmaf.yml #558

merged 1 commit into from
Apr 30, 2020

Conversation

1480c1
Copy link
Contributor

@1480c1 1480c1 commented Apr 27, 2020

Replicates some of the jobs in travis-ci

@1480c1
Copy link
Contributor Author

1480c1 commented Apr 27, 2020

How it looks on my repository https://github.com/1480c1/vmaf/actions/runs/88645912

@li-zhi
Copy link
Collaborator

li-zhi commented Apr 27, 2020

It looks like it ran the extratests (meant for tests with external dependency such as FFmpeg and Matlab). I added conditional skip for them. Please try again after rebasing master.

@1480c1
Copy link
Contributor Author

1480c1 commented Apr 27, 2020

Should I change this to always run on push and prs? Right now it's only running if there was a change to any of the workflows or under the libvmaf subfolder

@li-zhi
Copy link
Collaborator

li-zhi commented Apr 28, 2020

I am not familiar with the github workflow. How does it do differently than the travis CI? why do we need it since we already have travis CI?

@1480c1
Copy link
Contributor Author

1480c1 commented Apr 28, 2020

I am mainly thinking about moving some of the jobs from travis-ci to github ci, with the main purpose of spreading the number of jobs that are currently being run. Plus, I would consider github actions to have slightly better integration with pull requests since it will display a notification for each job separately rather than a single continuous-integration/travis-ci/pr

Also, I have a feeling that the reason why the python job is failing is that it can't find ffmpeg

@1480c1
Copy link
Contributor Author

1480c1 commented Apr 28, 2020

For example, from a different repo
image

@li-zhi
Copy link
Collaborator

li-zhi commented Apr 29, 2020

In this case, we can migrate to github ci and retire travis ci.

I pushed some changes to master. Hopefully it is going to fix the issue.

@li-zhi li-zhi merged commit 113bdb1 into Netflix:master Apr 30, 2020
@li-zhi
Copy link
Collaborator

li-zhi commented Apr 30, 2020

@1480c1 would you also help add a "build" badge to the README.md for github ci?

@1480c1 1480c1 deleted the githubactions branch April 30, 2020 00:22
@1480c1
Copy link
Contributor Author

1480c1 commented Apr 30, 2020

@1480c1 would you also help add a "build" badge to the README.md for github ci?

Sure, I can do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants