Register the allocator memory metric polled gauge only once #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // All channels should share a single ByteBufAllocator instance. | ||
| // Add metrics to monitor that allocator's memory usage. | ||
| if (!allBindFutures.isEmpty()) { |
There was a problem hiding this comment.
Should this conditional be inverted?
There was a problem hiding this comment.
We want to check here that the allbindFutures list is not empty because in line 201 we fetch the first entry. The conditional looks correct to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously registered a polled gauge for each port. If you register a polled gauge multiple times with the same id, then it will sum the corresponding values. This was causing our memory metrics to report x N as the actual value (where N is number of ports).
All channels should be sharing the same allocator instance, so we only need to register the gauge once. Querying this metric also acquires a lock on each arena.