Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Netty io_uring transport #1146

Merged
merged 27 commits into from
Jan 31, 2022
Merged

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Dec 9, 2021

@sullis
Copy link
Contributor Author

sullis commented Dec 9, 2021

fyi @normanmaurer

@normanmaurer
Copy link

nice...!

@sullis
Copy link
Contributor Author

sullis commented Dec 9, 2021

Work in progress
cc: @artgon

@sullis sullis force-pushed the netty-io-uring branch 6 times, most recently from 14fb4d8 to 4c31652 Compare December 16, 2021 04:13
@sullis
Copy link
Contributor Author

sullis commented Jan 4, 2022

@argha-c This is a draft PR of io_uring support. WDYT?

@sullis sullis marked this pull request as ready for review January 15, 2022 18:29
@sullis
Copy link
Contributor Author

sullis commented Jan 15, 2022

I rebased this PR with the master branch.

Ready for review @argha-c

@artgon
Copy link
Contributor

artgon commented Jan 28, 2022

I think this is really cool, but seems like it's "incubator" mode so we're unlikely to run it in production (yet). I'm open to merging it to allow people to play around with it but it won't have the kind of verification that the rest of the code has.

@sullis
Copy link
Contributor Author

sullis commented Jan 28, 2022

I think this is really cool, but seems like it's "incubator" mode so we're unlikely to run it in production (yet). I'm open to merging it to allow people to play around with it but it won't have the kind of verification that the rest of the code has.

Agreed. It is an "incubator" feature. I think it would be good to merge it so that folks can play around with it.

@sullis
Copy link
Contributor Author

sullis commented Jan 28, 2022

I resolved all merge conflicts.

@argha-c
Copy link
Collaborator

argha-c commented Jan 28, 2022

@sullis : Thanks for addressing the feedback so far. We're definitely open to merging it, and appreciate your contributions.

If you could consolidate and exercise the tests in our regular module (now that we have the FP), I think it'd be more valuable than introducing a separate test module altogether.

@sullis
Copy link
Contributor Author

sullis commented Jan 29, 2022

@sullis : Thanks for addressing the feedback so far. We're definitely open to merging it, and appreciate your contributions.

If you could consolidate and exercise the tests in our regular module (now that we have the FP), I think it'd be more valuable than introducing a separate test module altogether.

I moved IoUringTest.java to zuul-core

Is this ok or should I move the test case into ServerTest.java ?

@argha-c
Copy link
Collaborator

argha-c commented Jan 29, 2022

LGTM. Please rebase and resolve conflicts.

@sullis
Copy link
Contributor Author

sullis commented Jan 29, 2022

LGTM. Please rebase and resolve conflicts.

Done.

@argha-c argha-c merged commit 5c407c2 into Netflix:master Jan 31, 2022
argha-c pushed a commit to argha-c/zuul that referenced this pull request Mar 22, 2022
@sullis sullis deleted the netty-io-uring branch January 28, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants