-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Netty io_uring transport #1146
Conversation
sullis
commented
Dec 9, 2021
•
edited
Loading
edited
- https://en.wikipedia.org/wiki/Io_uring
- https://github.com/netty/netty-incubator-transport-io_uring
fyi @normanmaurer |
nice...! |
Work in progress |
14fb4d8
to
4c31652
Compare
@argha-c This is a draft PR of io_uring support. WDYT? |
zuul-core/src/main/java/com/netflix/zuul/netty/server/Server.java
Outdated
Show resolved
Hide resolved
zuul-io-uring-test/src/test/java/com/netflix/zuul/netty/server/IoUringTest.java
Outdated
Show resolved
Hide resolved
zuul-io-uring-test/src/test/java/com/netflix/zuul/netty/server/IoUringTest.java
Outdated
Show resolved
Hide resolved
zuul-core/src/main/java/com/netflix/zuul/netty/server/Server.java
Outdated
Show resolved
Hide resolved
zuul-io-uring-test/src/test/java/com/netflix/zuul/netty/server/IoUringTest.java
Outdated
Show resolved
Hide resolved
e6f4c4f
to
bbdf051
Compare
I rebased this PR with the master branch. Ready for review @argha-c |
642ce1b
to
127b2aa
Compare
I think this is really cool, but seems like it's "incubator" mode so we're unlikely to run it in production (yet). I'm open to merging it to allow people to play around with it but it won't have the kind of verification that the rest of the code has. |
Agreed. It is an "incubator" feature. I think it would be good to merge it so that folks can play around with it. |
I resolved all merge conflicts. |
@sullis : Thanks for addressing the feedback so far. We're definitely open to merging it, and appreciate your contributions. If you could consolidate and exercise the tests in our regular module (now that we have the FP), I think it'd be more valuable than introducing a separate test module altogether. |
I moved IoUringTest.java to zuul-core Is this ok or should I move the test case into ServerTest.java ? |
LGTM. Please rebase and resolve conflicts. |
e3b5d5c
to
9638e2b
Compare
Done. |