Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify listening addresses in ServerTest #1175

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Jan 15, 2022

No description provided.

out.flush();
out.close();
} catch (IOException ex) {
throw new RuntimeException(ex);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fail(msg)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

try {
sock.close();
}
catch (Exception ignored) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: formatting {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sullis
Copy link
Contributor Author

sullis commented Jan 23, 2022

can you merge this? @argha-c

@argha-c argha-c merged commit 7e8b022 into Netflix:master Jan 24, 2022
argha-c pushed a commit to argha-c/zuul that referenced this pull request Mar 22, 2022
* verify listening addresses in ServerTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants