Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerTest verifies the number of NioSocketChannel's #1194

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 3, 2022

No description provided.

@sullis
Copy link
Contributor Author

sullis commented Feb 4, 2022

wdyt? @argha-c

@@ -68,9 +71,20 @@ public void beforeTest() {
public void getListeningSockets() throws Exception {
ServerStatusManager ssm = mock(ServerStatusManager.class);
Map<NamedSocketAddress, ChannelInitializer<?>> initializers = new HashMap<>();
final List<NioSocketChannel> nioChannels = Collections.synchronizedList(new ArrayList<NioSocketChannel>());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this specific to NIO channels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this specific to NIO channels?

ServerTest uses force_nio true

config.setProperty("zuul.server.netty.socket.force_nio", "true");

so the channels should be NioSocketChannel objects

Copy link
Collaborator

@argha-c argha-c Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I'd forgotten we updated that in the last change.

@argha-c argha-c merged commit 083e600 into Netflix:master Feb 8, 2022
argha-c pushed a commit to argha-c/zuul that referenced this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants