Do not propagate exception once context has been closed in PushRegistrationHandler #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
gavinbunney
reviewed
Aug 9, 2022
| @@ -95,10 +95,9 @@ public final void channelInactive(ChannelHandlerContext ctx) throws Exception { | |||
| } | |||
|
|
|||
| @Override | |||
| public final void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { | |||
| public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { | |||
| logger.error("Exception caught, closing push channel for " + authEvent, cause); | |||
| ctx.close(); | |||
There was a problem hiding this comment.
Should we shift to closing on flush (i.e. closeOnFlush) rather than explicit close here?
if (ctx.channel().isActive()) {
ctx.channel().writeAndFlush(Unpooled.EMPTY_BUFFER).addListener(ChannelFutureListener.CLOSE);
}
There was a problem hiding this comment.
Synced offline — we can keep this change small and keep the close() behavior while still removing the final in case we (or anyone else) wants to override with the fancier closeOnFlush 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because PushRegistrationHandler handles the exception and closes the context, it does not need to pass the exception on past itself.
Also removed the
finalso it can be overridden.