PushRegistrationHandler holds onto ChannelHandlerContext references #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f channels that tear down early
|
Would be nice to have a test for this class, but otherwise, LGTM. |
artgon
approved these changes
Aug 30, 2022
gavinbunney
approved these changes
Aug 30, 2022
|
Added tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a client successfully authenticates
PushRegistrationHandlerregisters a timer torequestClientToCloseConnection. However, if the client connection terminates prematurely (connection reset, etc) the scheduled task does not go away and maintains a referenceChannelHandlerContext. This PR adds logic to track scheduled tasks and cancel them when the channel becomes inactive