Ensure response filters are not left waiting for buffered body #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artgon
requested review from
sullis,
jguerra,
gavinbunney,
kyagna and
AlexanderEllis
sullis
approved these changes
Oct 20, 2022
kyagna
approved these changes
Oct 20, 2022
gavinbunney
reviewed
Oct 21, 2022
| @@ -121,15 +122,18 @@ private void sendResponse(final StatusCategory statusCategory, final int status, | |||
| headers.add("Content-Length", "0"); | |||
| zuulResponse.finishBufferedBodyIfIncomplete(); | |||
| responseFilterChain.filter(zuulResponse); | |||
| fireEndpointFinish(true); | |||
| fireEndpointFinish(true, ctx); | |||
There was a problem hiding this comment.
One slight nuance here with the change to fireEndpointFinish, since we close out the body on L123 (zuulResponse.finishBufferedBodyIfIncomplete()) and fire into the response filter chain, I don't think the new finishResponseFilters function will have an issue as no filter should be waiting for a body - so will just be a no-op? Just double checking 😅
There was a problem hiding this comment.
True, but in the case of that static response, it won't pop into the if block that checks if the filter chain is waiting for a buffered body.
gavinbunney
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of client cancellations or connectivity errors, we may have a response filter chain hanging, waiting for a complete buffered body. The goal for this PR is to close out that filter chain and clean up any body chunks being processed.