Only touch bytebufs when doing advanced logging #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbunney
reviewed
Oct 20, 2022
zuul-core/src/main/java/com/netflix/netty/common/ByteBufUtil.java
Outdated
Show resolved
Hide resolved
gavinbunney
reviewed
Oct 20, 2022
| private static final boolean isAdvancedLeakDetection = | ||
| ResourceLeakDetector.getLevel() == PARANOID || ResourceLeakDetector.getLevel() == ADVANCED; | ||
|
|
||
| public static void touch(ReferenceCounted byteBuf, String hint, ZuulMessage msg) { |
There was a problem hiding this comment.
May be worthwhile using a String.format with hint, with vargs param instead of ZuulMessage param, to allow for future logging of other objects if required - would also mean could just have a single touch method
There was a problem hiding this comment.
I was thinking about that too, but String.format has terrible performance.
Co-authored-by: Gavin Bunney <409207+gavinbunney@users.noreply.github.com>
gavinbunney
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.