Properly apply socket options

[jguerra]

These errors have always annoyed me:

2023-09-08T15:30:58.748 WARN  [main] io.netty.bootstrap.ServerBootstrap: Unknown channel option 'SO_LINGER' for channel '[id: 0x08c9bd45]'
2023-09-08T15:30:58.748 WARN  [main] io.netty.bootstrap.ServerBootstrap: Unknown channel option 'SO_KEEPALIVE' for channel '[id: 0x08c9bd45]'
2023-09-08T15:30:58.748 WARN  [main] io.netty.bootstrap.ServerBootstrap: Unknown channel option 'TCP_NODELAY' for channel '[id: 0x08c9bd45]'

turns out we were attempting to apply the options incorrectly

[gavinbunney]

🤨 Does that mean we haven't had keepalive enabled at all? Looking at the docs, seems like that's the case, but more from server-side, so may cause more server-side closures... neat

[jguerra]

🤨 Does that mean we haven't had keepalive enabled at all? Looking at the docs, seems like that's the case, but more from server-side, so may cause more server-side closures... neat

Yeah, it has not been enabled. I expect the impact to be fairly minimal because TCP keepalives only occur after ~2 hours, and we have aggressive idle timeouts on all connections.