Add StatusCategory reason #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbunney
requested review from
jguerra,
argha-c,
kyagna,
lindseyreynolds and
AlexanderEllis
gavinbunney
commented
Nov 7, 2023
There was a problem hiding this comment.
Appreciate reviews on the descriptions here 🤞 determining actual usage & keeping things obvious is sometimes a challenge
karim-z
approved these changes
Nov 7, 2023
jguerra
approved these changes
Nov 7, 2023
| SUCCESS_NOT_FOUND( | ||
| ZuulStatusCategoryGroup.SUCCESS, | ||
| 3, | ||
| "Successful with no resource found"), // This is set on for all 404 responses |
There was a problem hiding this comment.
maybe something a little more explicit? "Successfully proxied. Origin indicated no resource found"..?
There was a problem hiding this comment.
Updated to: Successfully proxied, origin responded with no resource found
lindseyreynolds
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
reasonfield toStatusCategorywith default explanations for eachZuulStatusCategorytype.