Unwrap DecoderExceptions on connections (OriginConnectExceptions) into RequestAttempts #1727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During origin connection failures, netty throws a
DecoderException
. Currently it is passed through toRequestAttempt
and falls into the basicOriginConnectException
handling, that is, only the base class name is emitted.This change unwraps the
DecoderException
before creating theOriginConnectException
so the underlying cause is better propagated. This change also then further unwraps theOriginConnectException
in theRequestAttempt
class during ssl handshake failures so we know the actual cause of the ssl handshake failure.Before:
After: