Only capture first line of stacktrace for unexpected RequestAttempt exceptions #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbunney
requested review from
jguerra,
argha-c,
kyagna and
lindseyreynolds
gavinbunney
force-pushed
the
gavin/request-attempt-stack
branch
from
7d85153 to
0156d53
Compare
gavinbunney
force-pushed
the
gavin/request-attempt-stack
branch
from
0156d53 to
b5e5119
Compare
argha-c
reviewed
Jan 30, 2024
| @@ -340,7 +339,13 @@ public void setException(Throwable t) { | |||
| } else { | |||
| error = t.getMessage(); | |||
| exceptionType = t.getClass().getSimpleName(); | |||
| cause = Throwables.getStackTraceAsString(t); | |||
|
|
|||
| // for unexpected exceptions, just capture the first line of the stacktrace | |||
There was a problem hiding this comment.
If we're suppressing the trace, doesn't cause.getCause() != null ? cause.getCause().toString() : cause.toString()) give you the hint?
When we do suppress, consider making it conditional instead.
There was a problem hiding this comment.
Not quite - these are more "rare case" exceptions (like the test does for a h2stream exception), which don't have a cause attached as it's thrown from within netty handlers, and thus bubbled up from the Promises in ProxyEndpoint, so need to get more info from the stacktrace itself.
jguerra
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.